[duckdb] Fixed multi-store bug #1459
Merged
+116
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The view created by DuckDBDVRT was called current_version, so it could not work with multiple stores. Changed it so that the view inherits the store name instead. Miscellaneous build changes: - Fixed the duckdb exclusion rule in all-modules. - Bumped up the duckdb snapshot dep to the current latest one.
kvargha
reviewed
Jan 21, 2025
...nice-duckdb/src/test/java/com/linkedin/venice/duckdb/DuckDBDaVinciRecordTransformerTest.java
Show resolved
Hide resolved
...nice-duckdb/src/test/java/com/linkedin/venice/duckdb/DuckDBDaVinciRecordTransformerTest.java
Outdated
Show resolved
Hide resolved
kvargha
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The view created by DuckDBDVRT was called current_version, so it could not work with multiple stores. Changed it so that the view inherits the store name instead.
Miscellaneous build changes:
How was this PR tested?
New unit test.
Does this PR introduce any user-facing changes?