[vpj] Replace org.apache.kafka.common.TopicPartition with PubSubTopicPartition in VPJ #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushantmane
force-pushed
the
pubsub-improvements
branch
from
1e96c3b to
7cf7fd8
Compare
haoxu07
reviewed
Jan 22, 2025
...ts/venice-push-job/src/main/java/com/linkedin/venice/hadoop/input/kafka/KafkaInputSplit.java
Outdated
Show resolved
Hide resolved
...s/venice-push-job/src/main/java/com/linkedin/venice/hadoop/input/kafka/KafkaInputFormat.java
Show resolved
Hide resolved
This reverts commit 9d4995b.
sushantmane
force-pushed
the
pubsub-improvements
branch
from
7cf7fd8 to
8846302
Compare
haoxu07
approved these changes
Jan 22, 2025
|
Thanks, @haoxu07! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace org.apache.kafka.common.TopicPartition with PubSubTopicPartition in VPJ
Replace the usage of Kafka TopicPartition with Venice PubSubOffset instances to enable support for non-Kafka
pub-sub clients. This change is part of the broader effort to decouple Venice from Kafka-specific classes and
ensure compatibility with other pub-sub systems.
How was this PR tested?
Does this PR introduce any user-facing changes?