-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DVC] Add RequestBasedMetaRepository to enable metadata retrieval directly from server #1461
Closed
pthirun
wants to merge
28
commits into
linkedin:main
from
pthirun:feature/dvc-request-based-metadata
Closed
[DVC] Add RequestBasedMetaRepository to enable metadata retrieval directly from server #1461
pthirun
wants to merge
28
commits into
linkedin:main
from
pthirun:feature/dvc-request-based-metadata
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem store for forward compatibility support
Update fork
Update fork
Update fork
Update fork
pthirun
force-pushed
the
feature/dvc-request-based-metadata
branch
2 times, most recently
from
January 22, 2025 00:18
c3ab59e
to
ace1c85
Compare
Update fork
pthirun
force-pushed
the
feature/dvc-request-based-metadata
branch
from
January 23, 2025 00:30
ace1c85
to
dd6680f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary, imperative, start upper case, don't end with a period
This PR introduces the use of the
/store_properties/{store_name}
endpoint to retrieve and cache store metadata for the DaVinci client. The endpoint was implemented in the Venice Server in this PR: #1374.The
RequestBasedMetaRepository
leverages this endpoint to maintain a cache ofStore
andSchemaData
objects for requested stores. The cache is refreshed by theNativeMetadataRepository
, which this new class extends.By default, this feature is disabled in the
ClientConfig
passed to theNativeMetadataRepository
. The default configuration preserves the current behavior of using theThinClientMetaStoreBasedRepository
. The relevant configuration field isClientConfig.useRequestBasedMetaRepository
. For more details, see NativeMetadataRepository.getInstance.How was this PR tested?
Unit and Integration test included in PR.
Does this PR introduce any user-facing changes?