[vpj] Dual write push job detials report from VPJ to both parent and child region for push job system store replication mode migration #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…child region for push job system store replication mode migration
Comment on lines
+1887
to
+1888
| * If it is multi-region, it will dual write push job details to parent RT and child region RT. | ||
| * If it is single-region, it will only write push job details to child region RT. |
There was a problem hiding this comment.
Why can't parent controller write it to child colo's RT instead? Why do we need to make a controller client to an arbitrary child colo?
There was a problem hiding this comment.
There is also stuff in parent controller that emits metrics about push job success/failures that we'll need to handle
There was a problem hiding this comment.
Yeah you are right...I think I read the code wrong. It probably cannot work alone within VPJ changes. I will probably just change to dual write in parent controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[vpj] Dual write push job detials report from VPJ to both parent and child region for push job system store replication mode migration
Add a new controller to write to child fabric for push job details system store, so that when we migrate this particular system store to A/A mode, it will be able to receive updates.
How was this PR tested?
N/A
Does this PR introduce any user-facing changes?