Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 修改为1s #570

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: 修改为1s #570

merged 1 commit into from
Dec 5, 2024

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Dec 5, 2024

修改为1s

Log: 修改为1s

@myk1343
fix: 修改为1s
c38fe50 
修改为1s

Log: 修改为1s
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • QThread::msleep(1000); 可能会导致线程阻塞，影响程序性能和响应速度。
  • QFile dbusResult(reply.value()); 应该检查 reply.value() 是否为空，以避免潜在的空指针异常。

是否建议立即修改:

  • 是

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: max-lvs, myk1343

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit a3f1a94 into linuxdeepin:release/eagle Dec 5, 2024
7 checks passed
@myk1343 myk1343 deleted the uploadcode branch December 5, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-lvs max-lvs max-lvs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myk1343 @deepin-ci-robot @max-lvs