Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next] GWL: add custom labeled button width #12602

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

expiredhotdog
Copy link

Adds an option to the Grouped Window List applet to set a custom width for labeled buttons.

Also fixes a minor bug where the button label would not update properly after changing the settings. Aside from that, default behavior is unchanged.

@JosephMcc
Copy link
Contributor

It would be nice to see the bug fix done separate from the new option. Quite a few options were already removed from GWL because it's a bit of an over complicated mess. Not sure this one is really needed.

@expiredhotdog expiredhotdog force-pushed the grouped-window-list-dev branch from 2510456 to e22d393 Compare January 2, 2025 20:47
@expiredhotdog
Copy link
Author

expiredhotdog commented Jan 2, 2025

@JosephMcc I just realized that I probably misinterpreted what you meant. Would you like me to close this PR and open 2 new ones (or, just open a bug fix PR and drop the other changes)?

@JosephMcc
Copy link
Contributor

Not at the moment. Not sure what the feeling is for adding the setting, but the bug fix is pretty likely to get merged if it works :)

@clefebvre clefebvre changed the title GWL: add custom labeled button width [Next] GWL: add custom labeled button width Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants