Copy the original transmission UI in the transmission-web-control mod #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR build pushed to |
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hey team, what needs to happen here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
transmission-web-controlincludes a link on the top-right to open the original Transmission UI, which is broken when using this mod. This is because when installing the theme using the install script provided by the theme developers, it renames the original UI asindex.original.html- and keeps the other assets with the same name as they don't clash.Benefits of this PR and context:
Making the existing UI fully working, which involves being able to open the original UI under
index.original.htmlas that's what the theme has a link to.How Has This Been Tested?
Created my fork repo and dockerhub, built the mod with the github actions and deployed locally. Confirmed the link now works.
https://github.com/edvincent/docker-mods/tree/transmission-transmission-web-control
https://hub.docker.com/layers/edouardv/mods/transmission-transmission-web-control/images/sha256-5c5ef6ac19fe6479928df777c571e5070d26471599e3c299ae90b097e21f2cc6?context=explore
Source / References: