Apply suggestions from code review

Co-authored-by: Nitya Dhanushkodi <[email protected]>
linydquantil · Apr 11, 2022 · 21a88a8 · 21a88a8
1 parent 5edbd65
commit 21a88a8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/control-plane/connect-inject/endpoints_controller.go b/control-plane/connect-inject/endpoints_controller.go
@@ -178,7 +178,7 @@ func (r *EndpointsController) Reconcile(ctx context.Context, req ctrl.Request) (
 				serviceName, ok := pod.Annotations[annotationKubernetesService]
 				if ok && serviceEndpoints.Name != serviceName {
 					r.Log.Info("ignoring endpoint because it doesn't match explicit service annotation", "name", serviceEndpoints.Name, "ns", serviceEndpoints.Namespace)
-					// deregistration happens later because we don't add this pod to the endpointAddressMap
+					// deregistration for service instances that don't match the annotation happens later because we don't add this pod to the endpointAddressMap.
 					continue
 				}
 

diff --git a/control-plane/connect-inject/endpoints_controller_test.go b/control-plane/connect-inject/endpoints_controller_test.go
@@ -3491,7 +3491,7 @@ func TestReconcile_podSpecifiesExplicitService(t *testing.T) {
 
 	// Run the reconcile again with the service we want to register.
 	serviceName = endpoint.Name
-	namespacedName = types.NamespacedName{Namespace: badEndpoint.Namespace, Name: serviceName}
+	namespacedName = types.NamespacedName{Namespace: endpoint.Namespace, Name: serviceName}
 	resp, err = ep.Reconcile(context.Background(), ctrl.Request{NamespacedName: namespacedName})
 	require.NoError(t, err)
 	require.False(t, resp.Requeue)