Critical fixes in handling resolving cryptomator v7 folder uuid, and 2 other minor changes. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shural
commented
Dec 27, 2020
shural
commented
- Fix core data merge conflict in FileCache, context.save()
- Fix task synchronization in getting folder uuid in WebDAVStorage
- Replace some prints with os_log.
2. Fix task synchronization in getting folder uuid in WebDAVStorage 3. Replace some prints with os_log.
…upport for FromTemplate in editor.
…annotation in ViewControllerImage.
…iddle, and then the picture.
…ARK", as FFMPEG does not build and also enable real device debugging w/o Apple developer account. 2. GPS view changed to hybrid.
Adlai-Holler
reviewed
Feb 6, 2021
| data.withUnsafeBytes { | ||
| let bytes = $0.baseAddress?.assumingMemoryBound(to: UInt8.self) | ||
| if let cfData = CFDataCreate(kCFAllocatorDefault, bytes, data.count), | ||
| let source = CGImageSourceCreateWithData(cfData, nil) { |
There was a problem hiding this comment.
Encoding the entire image just to get the exif data from it? That's pretty yucky. Can we go find the original file instead?
If we have to do this, at least cast the data to a CFData instead of copying the whole thing.
EDIT: NM I just read the comment. Yeah we need to go find the original encoded NSData for the image – UIImage is too late.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.