Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glossing sort depends on the dictionary glossLanguages order #270

Merged
merged 8 commits into from
Jan 20, 2023

Conversation

Danble
Copy link
Collaborator

@Danble Danble commented Jan 17, 2023

Relevant Issue

Summarize what changed in this PR (for developers)

This is a partial change to relief the needs of the Mayunmarka community to display a specific order in their glosses.
It will also work for the new functionality I'm working on since it will always load the order from the specific dictionary.glossLanguages field

How can the changes be tested?

/bezhta/entries/list
(I changed the russian gloss to be the first in development DB)
https://living-dictionaries-cycci68yd-livingtongues.vercel.app/bezhta/entries/list

Checklist before marking ready to merge

Please keep it in draft mode until these are completed:

  • Equal time was spent cleaning the code as writing it (Boy Scout Rule)
    • Functions
      • Functions that don't belong in Svelte components are extracted out into .ts files
      • Functions are short and well named
      • Concise tests are written for all functions
    • Classes (a Svelte Component is a Class)
      • Svelte components are broken down into smaller components so that each component is responsible for one thing (Single Responsibility Principle)
      • Stories/variants are written to describe use cases
    • Comments are only included when absolutely necessary information that cannot be explained in code is needed

@vercel
Copy link

vercel bot commented Jan 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
living-dictionaries ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 6:18PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
ld-parts ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:18PM (UTC)

@github-actions
Copy link

github-actions bot commented Jan 17, 2023

⚡️ Running Svelte-Check, Jest tests, and Lighthouse audit...

Copy link
Collaborator

@jacob-8 jacob-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my changes, then merge.

packages/site/src/lib/helpers/glosses.ts Outdated Show resolved Hide resolved
@Danble Danble merged commit 80d973e into main Jan 20, 2023
@Danble Danble deleted the temporal-mayunmarka-glossing-sort branch January 20, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants