-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glossing sort depends on the dictionary glossLanguages order #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
⚡️ Running Svelte-Check, Jest tests, and Lighthouse audit... |
…nto temporal-mayunmarka-glossing-sort
jacob-8
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review my changes, then merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue
Summarize what changed in this PR (for developers)
This is a partial change to relief the needs of the Mayunmarka community to display a specific order in their glosses.
It will also work for the new functionality I'm working on since it will always load the order from the specific
dictionary.glossLanguages
fieldHow can the changes be tested?
/bezhta/entries/list
(I changed the russian gloss to be the first in development DB)
https://living-dictionaries-cycci68yd-livingtongues.vercel.app/bezhta/entries/list
Checklist before marking ready to merge
Please keep it in draft mode until these are completed:
.ts
files