Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fdroid] inform user of tracking #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samtinel
Copy link

@samtinel samtinel commented Jun 6, 2021

Reworked the message to take out the "adversariel" nature of it.
Please don't instantly close the issue if you still have concerns, let's try to create a solution which one the one hand empowers the user to make an informed choice, and on the other fits your vision for the project.

@samtinel samtinel changed the title [fdroid] add warning for nationstates.net tracking [fdroid] inform user of tracking Jun 6, 2021
@lloydtorres
Copy link
Owner

lloydtorres commented Jun 16, 2021

Slightly better, but still not quite user friendly. A non-technical user would have no idea what a WebView is. Please take a look at some of the other dialogs within the app for string examples.

It would also be better if the disclaimer on Google Analytics is shown in a smaller, more subtle font style. Take a look at the "Send Telegram" option under Settings for an example.

As with any UI change, please take a screenshot of the proposed UI changes and attach it to the pull request.

nationstates.net uses Google Analytics
informs user about tracking when clicking "create new nation", and now
offers to open it in a browser also
@samtinel
Copy link
Author

samtinel commented Jul 16, 2021

I have simplified it as much as I can, it's now mostly the same as before.
As per my own research, I can't really change the font (size) in the pop-up, without a substantial amount of code (pollution). In my opinion this is a good compromise between simplicity and necessary information.
Screenshot:
image
As this is a native dialog, it obviously varies based on the version of Android.

@IzzySoft
Copy link

@lloydtorres will this be merged anytime soon? Your app is still pending its listing on F-Droid, just waiting for this one. That merge request would now enter pre-closure state for missing feedback. Would be a real pity, as apart from this the entire review passed. Maybe you could merge this for now, and apply the polish later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants