Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onnx sinh lowering #3253

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix onnx sinh lowering #3253

merged 1 commit into from
Apr 30, 2024

Conversation

jinchen62
Copy link
Collaborator

@jinchen62 jinchen62 commented Apr 29, 2024 •
edited
Loading

iree tests test_sinh and test_sinh_example passed

@jinchen62 jinchen62 force-pushed the fix_sinh branch 2 times, most recently from 06aff17 to 0f44447 Compare April 29, 2024 00:57
@jinchen62 jinchen62 merged commit b64c22c into llvm:main Apr 30, 2024
3 checks passed
@jinchen62 jinchen62 deleted the fix_sinh branch April 30, 2024 07:44
@jinchen62 jinchen62 mentioned this pull request Apr 30, 2024
Closed
@rsuderman
Copy link
Contributor

rsuderman commented May 1, 2024 •
edited
Loading

@jinchen62 We should revert this and instead fix the math dialects lowerings for hyperbolic functions, we should not be decomposing these during the lowering to torch. There are better numeric methods for evaluating sinh, cosh, etc than doing the explicit decomposition which is why the math dialect exists.

rsuderman added a commit to rsuderman/torch-mlir that referenced this pull request May 1, 2024
@rsuderman
Revert "Fix onnx sinh lowering (llvm#3253)"
5596464 
This reverts commit b64c22c.
archana-ramalingam pushed a commit to archana-ramalingam/torch-mlir that referenced this pull request May 8, 2024
@jinchen62 @archana-ramalingam
Fix onnx sinh lowering (llvm#3253)
8244047 
iree tests `test_sinh` and `test_sinh_example` passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekkhandelwal1 vivekkhandelwal1 vivekkhandelwal1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinchen62 @rsuderman @vivekkhandelwal1