Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torch] Add OnnxToTorch lowering for onnx.HammingWindow #3283

Merged
merged 2 commits into from
May 6, 2024

Conversation

vinayakdsci
Copy link
Contributor

Adds OnnxToTorch lowering for the onnx.HammingWindow op.

@vinayakdsci
Copy link
Contributor Author

cc @renxida.

Copy link
Collaborator

@renxida renxida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. feel free to merge after merging numerical test.

lib/Conversion/TorchOnnxToTorch/DefaultDomainAtoF.cpp Outdated Show resolved Hide resolved
@vinayakdsci vinayakdsci force-pushed the hamming-window-impl branch from 33dd9e7 to ba20c78 Compare May 5, 2024 13:42
@vivekkhandelwal1
Copy link
Collaborator

@vinayakdsci, it would be helpful if you can leave a comment on #3283 when you start working on an op so that no two person works on the same op.

@vinayakdsci
Copy link
Contributor Author

@vinayakdsci, it would be helpful if you can leave a comment on #3283 when you start working on an op so that no two person works on the same op.

Understood, will do.

@renxida
Copy link
Collaborator

renxida commented May 6, 2024

nod-ai/SHARK-TestSuite#222

Tested here

@renxida renxida merged commit 6f911ba into llvm:main May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants