-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Torch] Add decomposition for 1d torch.nonzero #3876
Conversation
CI failed at MaskedScatterStaticBasic_basic_nonzerofailed.mlir, which lower to onnx.NonZero
|
The issue probably arise from the
|
After add dynamic support for AtenArangeStartStepOp, iree linalg bug move forward to
If test only with torch-mlir
|
e0312f9
to
1ac257b
Compare
Even with static
|
508be9f
to
7000a36
Compare
cc96514
to
b3d7d23
Compare
1330e55
to
7f469c7
Compare
ca88507
to
88836c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need to clean up the code.
This reverts commit 51da49c.
Target model:
migraphx_onnx-model-zoo__gpt2-10
%350 = torch.operator "onnx.NonZero"(%349) : (!torch.vtensor<[?],si64>) -> !torch.vtensor<[1,?],si64>
The python implementation: nonzero.py and decompose e2etest
To fix e2e test error in xida's previous draft #3721
Here is the bug and reproducer mlir: https://gist.github.com/AmosLewis/92717dbe4847649afefc915425629124
Related iree issue to be fixed: iree-org/iree#19481