[MLIR][TORCH] Add support for 1-d group convolution #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekkhandelwal1
force-pushed
the
fix-conv
branch
2 times, most recently
from
fd98ffe to
fd771f0
Compare
zjgarvey
requested changes
Dec 10, 2024
This commit adds the support for 1-d group convolution by transforming it into a 2-d group convolution which is already supported. This commit also refactors the unsqueeze and squeeze tensor utility. Signed-off-by: Vivek Khandelwal <[email protected]>
vivekkhandelwal1
force-pushed
the
fix-conv
branch
from
99943ef to
0eeecdc
Compare
I have already made those changes and replaced the code. Could you please re-check? Or, let me know if I am missing something. |
zjgarvey
approved these changes
Dec 12, 2024
rahuls-cerebras
added a commit
that referenced
this pull request
Jan 3, 2025
This reverts commit 8e0eafd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the support for 1-d group convolution by transforming it into a 2-d group convolution which is already supported.
This commit also refactors the unsqueeze and squeeze tensor utility.