Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model_chatglm.py #2766

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update model_chatglm.py #2766

wants to merge 6 commits into from

Conversation

dbtzy
Copy link

@dbtzy dbtzy commented Dec 2, 2023

Why are these changes needed?

Add a 'stop' action similar to OpenAI's to halt further token generation.

Reference code: https://github.com/THUDM/ChatGLM3/blob/main/openai_api_demo/utils.py

Related issue number (if applicable)

Checks

  • I've run format.sh to lint the changes in this PR.
  • I've included any doc changes needed.
  • I've made sure the relevant tests are passing (if applicable).

dbtzy added 2 commits December 2, 2023 20:52
Add a 'stop' action similar to OpenAI's to halt further token generation.

Reference code: https://github.com/THUDM/ChatGLM3/blob/main/openai_api_demo/utils.py
@dbtzy dbtzy closed this Dec 9, 2023
@dbtzy dbtzy reopened this Dec 9, 2023
fastchat/model/model_chatglm.py Outdated Show resolved Hide resolved
Copy link
Member

@merrymercy merrymercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Could you resolve the conflict?

fastchat/model/model_chatglm.py Outdated Show resolved Hide resolved
@dbtzy dbtzy requested a review from merrymercy May 16, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants