Inference stop_str missing filter fix #2792
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The original logic will only find the last<| im_end|> through rfind, which in turn leads to filtering failure.
2. When no stop is generated and "rfind_start" is not updated, the starting position is always found, which is time-consuming.
3. Determine the search subset based on the maximum "stop_token" length to improve search efficiency.
Related issue number (if applicable)
Checks
format.sh
to lint the changes in this PR.