-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UNSAFE classname test #1826
base: main
Are you sure you want to change the base?
UNSAFE classname test #1826
Conversation
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
props: HTMLAttributes<HTMLElement>; | ||
}; | ||
|
||
export function useStyleProps<T extends StyleProps>(props: T): StylePropsResult { | ||
const classNamePrefix = useContext(ClassNamePrefixContext); | ||
const { UNSAFE_className, UNSAFE_style, ...otherProps } = props; | ||
const { UNSAFE_className, UNSAFE_style, ElementTag, ...otherProps } = props; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I think we should pass here only the bool value and not the entire ElementTag/Component.
4b6dfe6
to
ae48bf1
Compare
squashed and rebased with main |
I am still having a hard time doing what I want to do.
Simple example to try this is to rebase |
Description
UNSAFE_className
andUNSAFE_style
(html, spirit components, other components)Additional context
Issue reference
(UNSAFE_)className v elementType komponentach