Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Introduce Skeleton component #DS-1625 #1863

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

katerinarehorkova
Copy link

Description

  • New component Skeleton
  • only web package implementation

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-1625

@katerinarehorkova katerinarehorkova added the feature New feature or request label Jan 22, 2025
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 22afb17
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67933ba88861d30008473454

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 22afb17
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67933ba85b68b90008436616
😎 Deploy Preview https://deploy-preview-1863--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

</div>
```

## Headline
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (blocking): I think this will be Heading and the class name will be Skeleton--heading. Because we have a Heading component and the same is the token name. https://spirit-design-system.netlify.app/packages/web/src/scss/helpers/typography/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, you have heading in the CSS, so it is not correct only in the examples.

@literat
Copy link
Collaborator

literat commented Jan 22, 2025

👏 Great, nice first PR and contribution to the Spirit Design System 🎉

When I switch the demo to the "Light on brand" theme, the animation and color are missing. I think that this should be the same as the default. But not sure. @crishpeen

Screenshot 2025-01-22 at 12 51 36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants