-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(web): Introduce Skeleton component #DS-1625 #1863
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
</div> | ||
``` | ||
|
||
## Headline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (blocking): I think this will be Heading
and the class name will be Skeleton--heading
. Because we have a Heading
component and the same is the token name. https://spirit-design-system.netlify.app/packages/web/src/scss/helpers/typography/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, you have heading
in the CSS, so it is not correct only in the examples.
👏 Great, nice first PR and contribution to the Spirit Design System 🎉 When I switch the demo to the "Light on brand" theme, the animation and color are missing. I think that this should be the same as the default. But not sure. @crishpeen |
Description
Additional context
Issue reference
https://jira.almacareer.tech/browse/DS-1625