Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing presentation role to Tabs Item #DS-1653 in 2.x version #1867

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@github-actions github-actions bot added the bug Something isn't working label Jan 23, 2025
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit ae39b77
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/679256f447e6890008793692
😎 Deploy Preview https://deploy-preview-1867--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit ae39b77
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/679256f4b18ee500088acab4
😎 Deploy Preview https://deploy-preview-1867--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (🟢 up 2 from production)
Best Practices: 100 (no change from production)
SEO: 90 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants