Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: temporarily disable S3 client integrity check for Cloudflare R2 #5479

Merged
merged 2 commits into from
Jan 17, 2025
Merged

🐛 fix: temporarily disable S3 client integrity check for Cloudflare R2 #5479

merged 2 commits into from
Jan 17, 2025

Conversation

CloudPassenger
Copy link
Contributor

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

The latest version of @aws-sdk/client-s3 introduced a default integrity check for all requests, which is incompatible with Cloudflare R2. This workaround is to temporarily disable the checksum.

📝 补充信息 | Additional Information

Related topics:

@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025

@CloudPassenger is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @CloudPassenger

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐛 Bug Something isn't working | 缺陷 labels Jan 16, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.92%. Comparing base (bcea920) to head (cf55bc8).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/server/modules/S3/index.ts 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5479      +/-   ##
==========================================
- Coverage   92.93%   92.92%   -0.01%     
==========================================
  Files         636      636              
  Lines       55552    55562      +10     
  Branches     2681     4220    +1539     
==========================================
+ Hits        51627    51632       +5     
- Misses       3925     3930       +5
Flag Coverage Δ
app 92.92% <0.00%> (-0.01%) ⬇️
server 97.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx arvinxx merged commit a638238 into lobehub:main Jan 17, 2025
2 of 5 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @CloudPassenger ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jan 17, 2025
@semantic-release-bot
🔖 chore(release): v1.46.7 [skip ci]
0e073ad 
### [Version&nbsp;1.46.7](v1.46.6...v1.46.7)
<sup>Released on **2025-01-17**</sup>

#### 🐛 Bug Fixes

- **misc**: Improve validation for provider and model in parseFilesConfig, temporarily disable S3 client integrity check for Cloudflare R2.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Improve validation for provider and model in parseFilesConfig, closes [#5454](#5454) ([b4808f8](b4808f8))
* **misc**: Temporarily disable S3 client integrity check for Cloudflare R2, closes [#5479](#5479) ([a638238](a638238))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.46.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jan 17, 2025
@semantic-release-bot
🔖 chore(release): v1.88.5 [skip ci]
beb73b7 
### [Version&nbsp;1.88.5](v1.88.4...v1.88.5)
<sup>Released on **2025-01-17**</sup>

#### 🐛 Bug Fixes

- **misc**: Improve validation for provider and model in parseFilesConfig, temporarily disable S3 client integrity check for Cloudflare R2.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Improve validation for provider and model in parseFilesConfig, closes [lobehub#5454](https://github.com/bentwnghk/lobe-chat/issues/5454) ([b4808f8](b4808f8))
* **misc**: Temporarily disable S3 client integrity check for Cloudflare R2, closes [lobehub#5479](https://github.com/bentwnghk/lobe-chat/issues/5479) ([a638238](a638238))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
gecsp pushed a commit to gecsp/lobe-chat that referenced this pull request Jan 22, 2025
@CloudPassenger @arvinxx @gecsp
🐛 fix: temporarily disable S3 client integrity check for Cloudflare R2 (
0508604 
lobehub#5479)

* 🐛 fix: S3 client integrity check for Cloudflare R2

related issues:
cloudflare/cloudflare-docs#19236
aws/aws-sdk-js-v3#6810

* Update index.ts

---------

Co-authored-by: Arvin Xu <[email protected]>
gecsp pushed a commit to gecsp/lobe-chat that referenced this pull request Jan 22, 2025
@semantic-release-bot @gecsp
🔖 chore(release): v1.46.7 [skip ci]
f5e6463 
### [Version&nbsp;1.46.7](lobehub/lobe-chat@v1.46.6...v1.46.7)
<sup>Released on **2025-01-17**</sup>

#### 🐛 Bug Fixes

- **misc**: Improve validation for provider and model in parseFilesConfig, temporarily disable S3 client integrity check for Cloudflare R2.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Improve validation for provider and model in parseFilesConfig, closes [lobehub#5454](lobehub#5454) ([b4808f8](lobehub@b4808f8))
* **misc**: Temporarily disable S3 client integrity check for Cloudflare R2, closes [lobehub#5479](lobehub#5479) ([a638238](lobehub@a638238))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvinxx arvinxx arvinxx left review comments

Assignees
No one assigned
Labels
🐛 Bug Something isn't working | 缺陷 released size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CloudPassenger @lobehubbot @arvinxx