Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs on rancher desktop #1631

Merged
merged 3 commits into from
Feb 10, 2025
Merged

add docs on rancher desktop #1631

merged 3 commits into from
Feb 10, 2025

Conversation

HarshCasper
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1631.surge.sh 🎊

drauedo
drauedo approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@drauedo drauedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 ! Thanks for having a look at my message yesterday and updating the docs accordingly. 🫶 🥇

@bartsdev
Copy link
Member

Some comments from me:

  • the placement of this instruction is not correct. It should be inside of the installation page.
  • I would divide the instructions based on OS (Mac/Linux, Windows) and simplify the guides
  • if you alias rancher to docker, shouldn't the localstack CLI work? If yes, then we should list that as an option.

bartsdev
bartsdev requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@bartsdev bartsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see overal comment

@HarshCasper HarshCasper merged commit 3ef5f59 into main Feb 10, 2025
5 checks passed
@HarshCasper HarshCasper deleted the rancher-desktop branch February 10, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsdev bartsdev bartsdev requested changes

@drauedo drauedo drauedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarshCasper @bartsdev @drauedo