Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to storage for session configuration containers #109 #2946

Merged
merged 1 commit into from
Jun 20, 2020

Conversation

joachimmetz
Copy link
Member

@joachimmetz joachimmetz commented May 21, 2020

Changed to storage for session configuration containers #109

@joachimmetz joachimmetz requested a review from Onager May 21, 2020 15:38
@joachimmetz joachimmetz added the blocked Work cannot progress until another issue is resolved label May 21, 2020
@joachimmetz joachimmetz force-pushed the sessioncfg3 branch 3 times, most recently from c73b013 to d093985 Compare June 1, 2020 05:27
@joachimmetz joachimmetz changed the title Changed storage to use session configuration #109 Changed to storage for session configuration #109 Jun 5, 2020
@joachimmetz joachimmetz changed the title Changed to storage for session configuration #109 Changed to storage for session configuration containers #109 Jun 5, 2020
@Onager Onager removed the blocked Work cannot progress until another issue is resolved label Jun 19, 2020
@Onager Onager changed the title Changed to storage for session configuration containers #109 Changes to storage for session configuration containers #109 Jun 19, 2020
@Onager Onager added the to merge Issue has been reviewed and can be merged when checks are complete label Jun 19, 2020
@joachimmetz joachimmetz assigned joachimmetz and unassigned Onager Jun 19, 2020
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #2946 into master will decrease coverage by 0.03%.
The diff coverage is 67.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2946      +/-   ##
==========================================
- Coverage   86.20%   86.17%   -0.04%     
==========================================
  Files         397      397              
  Lines       32475    32497      +22     
==========================================
+ Hits        27995    28004       +9     
- Misses       4480     4493      +13     
Impacted Files Coverage Δ
plaso/cli/log2timeline_tool.py 89.36% <ø> (ø)
plaso/cli/psteal_tool.py 88.79% <ø> (ø)
plaso/cli/pinfo_tool.py 65.85% <25.00%> (+0.49%) ⬆️
plaso/storage/redis/writer.py 54.11% <50.00%> (-0.10%) ⬇️
plaso/storage/interface.py 84.68% <56.75%> (-2.94%) ⬇️
plaso/cli/psort_tool.py 71.37% <60.00%> (-0.22%) ⬇️
plaso/storage/fake/writer.py 86.30% <83.33%> (+1.60%) ⬆️
plaso/storage/file_interface.py 73.69% <83.33%> (+0.05%) ⬆️
plaso/engine/knowledge_base.py 93.75% <100.00%> (+0.16%) ⬆️
plaso/engine/single_process.py 74.28% <100.00%> (+0.18%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95fd0f1...8a2fa0e. Read the comment docs.

@joachimmetz joachimmetz merged commit 4bec463 into log2timeline:master Jun 20, 2020
@joachimmetz joachimmetz removed the to merge Issue has been reviewed and can be merged when checks are complete label Jun 20, 2020
@joachimmetz joachimmetz deleted the sessioncfg3 branch June 20, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants