Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): added models option in lb4 discover cli command and its te… #8415

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Mar 21, 2022

…st and documentation

added --models option inside lb4 discover command to generate specific models

Signed-off-by: krishna yadav [email protected]

Include references to all related GitHub issues and other pull requests, for example:
Fixes #7104

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@ghost
Copy link
Author

ghost commented Mar 22, 2022

@raymondfeng
@achrinza
request you to check pull request and approve it

@achrinza
Copy link
Member

achrinza commented Apr 5, 2022

I've kickstarted the CI

@achrinza achrinza self-requested a review April 5, 2022 07:35
@cloud20x
Copy link

cloud20x commented Apr 5, 2022

I've kickstarted the CI

thx, we will look at it asap.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2095009029

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 76.598%

Totals Coverage Status
Change from base Build 2084348137: 0.007%
Covered Lines: 18069
Relevant Lines: 19176

💛 - Coveralls

Copy link
Member

@achrinza achrinza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍

Please remove the merge commit; If needed, use git rebase instead for resolving any merge conflicts with the base branch.

@ghost ghost requested a review from achrinza April 5, 2022 12:23
Copy link
Member

@achrinza achrinza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge commit still seems to be present. Feel free to reach out if you need assistance with this.

@ghost ghost requested a review from achrinza April 5, 2022 14:47
Add `--models` option for `lb4 discover` to selectively discover and generate models.

Signed-off-by: krishna yadav <[email protected]>
Signed-off-by: Rifa Achrinza <[email protected]>
@cloud20x
Copy link

@achrinza who has closed this PR? Can you please reopen it? Thanks...

@achrinza
Copy link
Member

@cloud20x The account which created the PR no longer exists. Hence we'll need to open a new PR to get it merged.

@coveralls
Copy link

coveralls commented Oct 22, 2024

Pull Request Test Coverage Report for Build 2095009029

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 76.934%

Totals Coverage Status
Change from base Build 2084348137: 0.3%
Covered Lines: 18036
Relevant Lines: 18987

💛 - Coveralls

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --tables/--models arguments to lb4 discover command
3 participants