-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): added models option in lb4 discover cli command and its te… #8415
Conversation
@raymondfeng |
I've kickstarted the CI |
thx, we will look at it asap. |
Pull Request Test Coverage Report for Build 2095009029
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM 👍
Please remove the merge commit; If needed, use git rebase
instead for resolving any merge conflicts with the base branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merge commit still seems to be present. Feel free to reach out if you need assistance with this.
Add `--models` option for `lb4 discover` to selectively discover and generate models. Signed-off-by: krishna yadav <[email protected]> Signed-off-by: Rifa Achrinza <[email protected]>
@achrinza who has closed this PR? Can you please reopen it? Thanks... |
@cloud20x The account which created the PR no longer exists. Hence we'll need to open a new PR to get it merged. |
Pull Request Test Coverage Report for Build 2095009029Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…st and documentation
added --models option inside lb4 discover command to generate specific models
Signed-off-by: krishna yadav [email protected]
Include references to all related GitHub issues and other pull requests, for example:
Fixes #7104
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈