Fixed implicitly nullable parameter #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes deprecation error in PHP 8.4
|
Cool, thanks for this! Would you like to add 8.4 to CI and remove 8.1? |
|
@lorisleiva I think it make sense to add php8.4 to the CI. And since the syntax that PR provided is valid with all php8 version, it's no big deal whether keep version 8.1 or not |
|
Hitting this issue today, came here to open a PR. would love to get this merged! |
This was referenced Dec 19, 2024
lorisleiva
pushed a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deprecation error in PHP 8.4