Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type segments instead for spans #191

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

matzipan
Copy link
Collaborator

@matzipan matzipan commented Jan 19, 2025

  • Fix all the other span() uses

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.51%. Comparing base (0f687ad) to head (0bfa285).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   71.51%   71.51%           
=======================================
  Files          83       83           
  Lines       21767    21767           
=======================================
  Hits        15567    15567           
  Misses       6200     6200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 19, 2025

CodSpeed Performance Report

Merging #191 will not alter performance

Comparing fix_generation_on_nightly (0bfa285) with main (0f687ad)

Summary

✅ 1 untouched benchmarks

@matzipan matzipan force-pushed the fix_generation_on_nightly branch 2 times, most recently from 1166462 to 112d971 Compare January 22, 2025 22:01
@helgee helgee force-pushed the fix_generation_on_nightly branch from 112d971 to 0bfa285 Compare January 23, 2025 06:42
@helgee helgee merged commit d0fae0a into main Jan 23, 2025
21 checks passed
@helgee helgee deleted the fix_generation_on_nightly branch January 23, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants