Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lox-orbits): parallelise visibility #195

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

helgee
Copy link
Member

@helgee helgee commented Jan 26, 2025

No description provided.

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 1.63934% with 60 lines in your changes missing coverage. Please review.

Project coverage is 70.08%. Comparing base (36bc243) to head (988aa2c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/lox-orbits/src/python.rs 0.00% 57 Missing ⚠️
crates/lox-space/src/lib.rs 0.00% 2 Missing ⚠️
crates/lox-orbits/src/trajectories.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   70.28%   70.08%   -0.20%     
==========================================
  Files          82       82              
  Lines       21430    21486      +56     
==========================================
- Hits        15062    15059       -3     
- Misses       6368     6427      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 26, 2025

CodSpeed Performance Report

Merging #195 will improve performances by 13.45%

Comparing he/extend-visibility (988aa2c) with main (36bc243)

Summary

⚡ 1 improvements

Benchmarks breakdown

Benchmark BASE HEAD Change
test_visibility_benchmark 628.9 ms 554.4 ms +13.45%

@helgee helgee force-pushed the he/extend-visibility branch from 2607731 to 988aa2c Compare January 27, 2025 11:26
@helgee helgee merged commit ef0ee74 into main Jan 27, 2025
20 of 22 checks passed
@helgee helgee deleted the he/extend-visibility branch January 27, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant