tickets/SITCOM-1799 #150
Open
tickets/SITCOM-1799 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Kelks19
reviewed
Jan 24, 2025
| @@ -0,0 +1,607 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,607 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,607 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,607 @@ | |||
| { | |||
There was a problem hiding this comment.
I think the block is redundant. The following block has some minor changes and that is the one you end up using.
Reply via ReviewNB
| @@ -0,0 +1,607 @@ | |||
| { | |||
There was a problem hiding this comment.
- Since the TMA Az and Elevation supporting information - I suggest including a textbox with their values instead of a common axis and plotting them
- You need to uncomment line 23 so that we get the legend of which color represents which HPs.
- Here it would make much more sense to separate out hardpoint forces in different panels to see their behaviour e.f HP 5 shows a different reaction and spread compared to others.
- You can offset each HPs in the same plot (you will need to include a note in markup because the y-axis won't reflect the the absolute values )
- create 5 panels for each force.
Reply via ReviewNB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notebook added to show HP forces when earthquake happens.