DM-47777: Write interface for SOAR seeing data #50
Conversation
mfisherlevine
force-pushed
the
tickets/DM-47777
branch
4 times, most recently
from
966a91c to
44969d7
Compare
mfisherlevine
force-pushed
the
tickets/DM-47777
branch
from
44969d7 to
2cf7984
Compare
mfisherlevine
force-pushed
the
tickets/DM-47777
branch
from
bd6e7a7 to
09e1bf5
Compare
mfisherlevine
force-pushed
the
tickets/DM-47777
branch
from
09e1bf5 to
00d0325
Compare
mfisherlevine
force-pushed
the
tickets/DM-47777
branch
from
600c1a5 to
9f7d659
Compare
| return None | ||
|
|
||
| @staticmethod | ||
| def adjustCoords(coords, height): |
There was a problem hiding this comment.
"Adjust" is super vague and any explanation of what this is doing would help.
See comment below about staticmethod.
| results = self.reader.readtext(dateImage, detail=0) | ||
| dateString = " ".join(results).strip() | ||
| # replace common OCR errors | ||
| dateString = dateString.replace(".", ":") |
| return astopyTime | ||
|
|
||
| @staticmethod | ||
| def thresholdImage(image, threshold): |
There was a problem hiding this comment.
All of these static methods are basically internal, so I would probably make them free functions and not export them.
| def thresholdImage(image, threshold): | ||
| return image.point(lambda x: 0 if x < threshold else 255, "L") | ||
|
|
||
| def _preprocessImage(self, image): |
There was a problem hiding this comment.
A one sentence description will help the future reader.
| imageBwNumpy = np.array(imageBw).astype(np.uint8) | ||
| return imageBwNumpy | ||
|
|
||
| def _getSeeingNumber(self, image) -> float: |
|
|
||
| SOAR_IMAGE_URL = "http://www.ctio.noirlab.edu/~soarsitemon/soar_seeing_monitor.png" | ||
|
|
||
| STORE_FILE = { |
There was a problem hiding this comment.
Hard coding this here seems like it's going to make this difficult to run in any other situation. I think it's better if these classes take filenames as parameters, and then the RA script specifies the full paths.
| self._reload() | ||
| return self.rowToSeeingConditions(self.df.iloc[-1]) | ||
|
|
||
| def getSeeingForDataId(self, butler: Butler, dataId: DataCoordinate) -> SeeingConditions: |
There was a problem hiding this comment.
I have a philosophical disagreement with this and getSeeingForExpRecord; this class doesn't need to know how to do butler things at all.
No description provided.