Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42201: Add flat core analysis tools pipeline #61

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Alex-Broughton
Copy link

No description provided.

@Alex-Broughton Alex-Broughton force-pushed the tickets/DM-42201 branch 3 times, most recently from 6e244df to e4dac0a Compare December 16, 2024 21:09
python/lsst/cp/verify/mergeResults.py Outdated Show resolved Hide resolved
python/lsst/cp/verify/mergeResults.py Show resolved Hide resolved
@czwa
Copy link
Collaborator

czwa commented Dec 16, 2024

This slipped my mind, but to add to this: If you add these new data products to python/lsst/cp/verify/configs/report.yaml, they will automatically be added to the cpv reports. The dataset_type_name is the key to the middle level dict, and should be (based on the analysis_tools changes) look like cpFlatDetMergeCore_flatTestsByDate_CalibAmpScatterTool using the outputName, the "test name" set under the atools header, and the output type.

@czwa
Copy link
Collaborator

czwa commented Dec 16, 2024

Sorry, cpFlatDetMergeCore_flatTestsByDate_GridPlot, I think is the right thing.

@czwa
Copy link
Collaborator

czwa commented Jan 17, 2025

This needs rebasing, which will hopefully get the gitignore update that will cause python/lsst_cp_verify.dist-info/METADATA to be ignored. If not, it should be removed from git manually. Otherwise, I'm happy here.

@timj
Copy link
Member

timj commented Jan 17, 2025

Rebasing won't cause the .dist-info to disappear -- the git ignore file does nothing after the fact. The commit that added it will have to be cleaned up.

@Alex-Broughton
Copy link
Author

Will do; will push my updated local branch when I finish fixing another ci_cpp error. Thanks for pointing it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants