DM-46942: Raise UpstreamFailureNoWorkFound in ReprocessVisitImageTask when detector is missing a necessary calibration #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
force-pushed
the
tickets/DM-46942
branch
from
d0fcabc to
f7dfadf
Compare
TallJimbo
approved these changes
Oct 18, 2024
| if detector_summary.apCorrMap is None: | ||
| msg += "\n > the aperture correction model map for the detector is None" | ||
| if detector_summary.photoCalib is None: | ||
| msg += "\n > the photometric calibration model for the detector is None" |
There was a problem hiding this comment.
It's not a big deal here, but when composing multi-line strings programmatically, it's usually better to append to a list of lines and use "\n".join(lines)" to stitch them together.
The main advantage is memory allocation efficiency, which only comes into play when there is a very large number of lines, but I think that makes it good practice for consistency everywhere.
There was a problem hiding this comment.
Always love a good best-practice coding tip from you 😄
| msg += "\n > the aperture correction model map for the detector is None" | ||
| if detector_summary.photoCalib is None: | ||
| msg += "\n > the photometric calibration model for the detector is None" | ||
| if len(msg) > 0: |
There was a problem hiding this comment.
if msg: is generally better (or if lines:, per the thread above).
tests/test_reprocess_visit_image.py
Outdated
| self.butler.put(lsst.afw.table.SourceCatalog().asAstropy(), "finalized_src_table", self.visit_only_id) | ||
| self.butler.put(make_visit_summary(detector=detector), "finalVisitSummary", self.visit_only_id) | ||
| # Make a simple single gaussian psf so that psf is not None in | ||
| # finalVisitSummary table whcih would result in |
There was a problem hiding this comment.
Suggested change
| # finalVisitSummary table whcih would result in | |
| # finalVisitSummary table which would result in |
If any of the relevant single frame calibrations are missing from the final visit summary table, a "calibrated" image cannot be created, so catch these and raise UpstreamFailureNoWorkFound so that we know there was a failure upstream, but that downstream tasks know to skip this dataId.
laurenam
force-pushed
the
tickets/DM-46942
branch
from
f7dfadf to
73cffd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.