DM-46939: make reprocessVisitImage usable without calibrateImage #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-46939
branch
2 times, most recently
from
0b23bd7 to
0156f94
Compare
Defaults are still set to use newer CalibrateImageTask outputs.
TallJimbo
force-pushed
the
tickets/DM-46939
branch
from
0156f94 to
a9eb27a
Compare
enourbakhsh
approved these changes
Oct 23, 2024
| # TODO (DM-46971): | ||
| # Now that we're running them before we apply the PhotoCalib to the | ||
| # image pixels, there's no need for post_calibrations to exist as | ||
| # as separate measurement instance from the main one (which is invoked |
There was a problem hiding this comment.
to exist as as separate measurement instance → to exist as a separate measurement instance
| # Now that we're running them before we apply the PhotoCalib to the | ||
| # image pixels, there's no need for post_calibrations to exist as | ||
| # as separate measurement instance from the main one (which is invoked | ||
| # (in _find_sources), but it's better to save removal (which may need |
There was a problem hiding this comment.
(which is invoked (in _find_sources) → (which is invoked in _find_sources)
This puts the output background and summary stats measurements in ADU, making them more consistent with other backgrounds and summary stats produced earlier in the pipeline, but inconsistent with the units of the "pvi" output image. It also makes the LocalWcs and LocalPhotoCalib plugin outputs reflect the transformation from ADU to nJy; I'm pretty sure they were previously just identities, which seems like it was probably a bug, unless downstream transform tasks had been configured to read "flux" fields rather than "instFlux" fields.
TallJimbo
force-pushed
the
tickets/DM-46939
branch
3 times, most recently
from
a9eb27a to
f69187c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.