DM-47738: Do not remove scarlet models while building catalog footprints #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranu
reviewed
Feb 6, 2025
| @@ -217,7 +217,7 @@ def from_butler( | |||
| catalog=catalog, | |||
| band=data_id["band"], | |||
| imageForRedistribution=exposure, | |||
| removeScarletData=True, | |||
| removeScarletData=False, | |||
There was a problem hiding this comment.
I think you mentioned that to accomplish the original goal of this line, you have to call... models_scarlet.clear() after the loop over bands? Is that right?
There was a problem hiding this comment.
You don't have to call that, and I think it would be something like models_scarlet.blends.clear(). I didn't bother because models_scarlet doesn't exist outside the scope of this method (I might not have realized that when we talked about it previously) so it will be garbage collected once this function is completed anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.