OPSIM-1102: feature. sim_runner pre-allocates array to hold observations. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehneilsen
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Looks fine.
I can imagine circumstances where using a nan might be a problem, for example if there are ever times when there might be an undefined RA, for example in the unlikely event that the telescope needs to track a quickly moving object (obviously not part of the main survey, but something that happens on telescopes). You could use counter in line 144 instead.
yoachim
force-pushed
the
tickets/OPSIM-1102
branch
from
a11dafb to
2394485
Compare
rhiannonlynne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
sim_runnerso it pre-allocates an array to hold observations. Results in a modest speedup, and makes it possible to keep the total memory footprint under 8 GB for a 10 year simulation.