Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PREOPS-4782: bug fix - when requesting time during the day, set available block size time to 0 #24

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

ehneilsen
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (611600c) 0.00% compared to head (5bbfc77) 0.00%.

Files Patch % Lines
rubin_scheduler/scheduler/surveys/surveys.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #24   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         91      91           
  Lines       9262    9262           
=====================================
  Misses      9262    9262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehneilsen ehneilsen force-pushed the tickets/PREOPS-4782 branch from c00f353 to 12e6c37 Compare January 18, 2024 20:35
Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this was Peter's recommendation and it seems to work.
You found this error was triggered by something, and if not too extensive, it would be good to add that unit test -- but I'm not sure how far you had to go to find the edge case.

@ehneilsen ehneilsen force-pushed the tickets/PREOPS-4782 branch from 12e6c37 to 0d55f5a Compare January 19, 2024 21:17
@ehneilsen ehneilsen force-pushed the tickets/PREOPS-4782 branch from 0d55f5a to deaaa5e Compare January 19, 2024 21:58
@ehneilsen
Copy link
Collaborator Author

Pretty sure this was Peter's recommendation and it seems to work. You found this error was triggered by something, and if not too extensive, it would be good to add that unit test -- but I'm not sure how far you had to go to find the edge case.

Okay, added a test.

@ehneilsen ehneilsen merged commit 8f817ac into main Jan 22, 2024
8 of 9 checks passed
@ehneilsen ehneilsen deleted the tickets/PREOPS-4782 branch January 22, 2024 14:56
@rhiannonlynne rhiannonlynne changed the title tickets/PREOPS-4782: when requesting time during the day, set available block size time to 0 PREOPS-4782: bug fix - when requesting time during the day, set available block size time to 0 Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants