Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PREOPS-4781: feature - make save of scheduler pickle work for arbitrary paths, not just from the current dir. #27

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

ehneilsen
Copy link
Collaborator

No description provided.

@ehneilsen ehneilsen requested a review from yoachim January 18, 2024 20:31
@ehneilsen ehneilsen force-pushed the tickets/PREOPS-4781 branch from 661f5b7 to f693c87 Compare January 18, 2024 20:37
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (caa633d) 0.00% compared to head (3772945) 0.00%.

Files Patch % Lines
rubin_scheduler/sim_archive/sim_archive.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #27   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         91      91           
  Lines       9262    9262           
=====================================
  Misses      9262    9262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yoachim yoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@ehneilsen ehneilsen force-pushed the tickets/PREOPS-4781 branch from f693c87 to 3772945 Compare January 19, 2024 20:46
@ehneilsen ehneilsen merged commit 2e3388b into main Jan 19, 2024
8 of 9 checks passed
@ehneilsen ehneilsen deleted the tickets/PREOPS-4781 branch January 19, 2024 21:11
@rhiannonlynne rhiannonlynne changed the title tickets/PREOPS-4781: make save of scheduler pickle work for arbitrary paths, not just from the current dir. PREOPS-4781: feature - make save of scheduler pickle work for arbitrary paths, not just from the current dir. Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants