prevent calling setState after component unmount

luchkonikita · Mar 7, 2016 · 081b916 · 081b916
1 parent b83034a
commit 081b916
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/lib/portal.js b/lib/portal.js
@@ -66,7 +66,7 @@ export default class Portal extends React.Component {
       document.removeEventListener('touchstart', this.handleOutsideMouseClick);
     }
 
-    this.closePortal();
+    this.closePortal(true);
   }
 
   shouldComponentUpdate(nextProps, nextState) {
@@ -108,15 +108,17 @@ export default class Portal extends React.Component {
     this.props.onOpen(this.node);
   }
 
-  closePortal() {
+  closePortal(isUnmounted = false) {
     const resetPortalState = () => {
       if (this.node) {
         ReactDOM.unmountComponentAtNode(this.node);
         document.body.removeChild(this.node);
       }
       this.portal = null;
       this.node = null;
-      this.setState({active: false});
+      if (!isUnmounted) {
+        this.setState({active: false});
+      }
     };
 
     if (this.state.active) {

diff --git a/test/portal_spec.js b/test/portal_spec.js
@@ -155,6 +155,15 @@ describe('react-portal', () => {
       unmountComponentAtNode(div);
       assert(props.onClose.calledOnce);
     });
+
+    it('should not call this.setState() if portal is unmounted', () => {
+      const div = document.createElement('div');
+      const props = {isOpened: true};
+      const wrapper = render(<Portal {...props}><p>Hi</p></Portal>, div);
+      spy(wrapper, 'setState');
+      unmountComponentAtNode(div);
+      assert.equal(wrapper.setState.callCount, 0);
+    });
   });
 
   describe('openByClickOn', () => {