Merge pull request tajo#40 from theaqua/patch-2

fix: use cloneElement instead of div.openByClickOn
luchkonikita · Feb 2, 2016 · 0e48366 · 0e48366
2 parents b313e70 + 9d594d8
commit 0e48366
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/portal.js b/lib/portal.js
@@ -89,7 +89,7 @@ export default class Portal extends React.Component {
 
   render() {
     if (this.props.openByClickOn) {
-      return <div className="openByClickOn" onClick={this.handleWrapperClick}>{this.props.openByClickOn}</div>;
+      return React.cloneElement(this.props.openByClickOn, {onClick: this.handleWrapperClick});
     } else {
       return null;
     }

diff --git a/test/portal_spec.js b/test/portal_spec.js
@@ -165,9 +165,10 @@ describe('react-portal', () => {
     });
 
     it('should render the props.openByClickOn element', () => {
-      const openByClickOn = <button>button</button>;
+      const text = `open by click on me`;
+      const openByClickOn = <button>${text}</button>;
       const wrapper = mount(<Portal openByClickOn={openByClickOn}><p>Hi</p></Portal>);
-      assert(wrapper.contains(openByClickOn));
+      assert(wrapper.text(text));
     });
 
     it('should open portal when clicking openByClickOn element', () => {