Add materialized view support helpers. #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
commented
Feb 11, 2024
Comment on lines
+17
to
+20
| {% if named_args[:materialized_view] %} | ||
| def self.refresh_view(*, concurrent : Bool = false) | ||
| {{ type }}.database.exec("REFRESH MATERIALIZED VIEW #{concurrent ? "CONCURRENTLY" : ""} #{{{ type }}.table_name}") | ||
| end |
There was a problem hiding this comment.
If you don't pass in this arg, should I still define the method, but raise an exception that tells you the model isn't defined as a materialzed view? 🤔
jwoertink
commented
Feb 11, 2024
Comment on lines
+2
to
+4
| view :all_the_names, materialized: true do | ||
| column name : String | ||
| end |
There was a problem hiding this comment.
These technically fail on the SchemaEnforcer... Should materialized views call skip_schema_enforcer by default, or would it be better to figure out why they fail?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #842
Avram already supports views and materialized views by way of writing custom SQL for the migration, and specifying
viewin your model.This PR gives you an easier way to see when a view model is materialized, as well as a handy helper method to refresh the materialized view.