Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Text-Domain #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Missing Text-Domain #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f8622b
Add Missing Text-Domain
alexclassroom Apr 28, 2021
d157654
Add Missing Text-Domain
alexclassroom Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build/inc/FLoC/Component.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,18 +59,18 @@ public function initialize_floc_blocking() {
public function blocking_methods( $methods = array() ) {

$methods['none'] = array(
'title' => __( 'None / Allow FLoC' ),
'title' => __( 'None / Allow FLoC', 'wpm-floc' ),
'description' => __( 'This method does not provide an opt-out from FLoC.', 'wpm-floc' ),
);

$methods['simple'] = array(
'title' => __( 'Simple / PHP' ),
'callback' => array( $this, 'initialize_simple' ),
'callback' => array( $this, 'initialize_simple', 'wpm-floc' ),
Comment on lines 67 to +68
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not the maintainer and not sure if/when/or how the PR will get merged. Just browsed by out of interest and saw this; Seems, you did choose the wrong line for the text domain. Should have been added in L67 imo.

'description' => __( 'Works for most WordPress setups. Uses the "wp_headers" filter to provide the HTTP header.', 'wpm-floc' ),
);

$methods['apache'] = array(
'title' => __( 'Apache / .htaccess' ),
'title' => __( 'Apache / .htaccess', 'wpm-floc' ),
'callback' => array( $this, 'initialize_apache' ),
'description' => __( 'When you have to circumvent your cache. Works on apache servers with the "mod_headers" module installed. Writes the header into the .htaccess file.', 'wpm-floc' ),
);
Expand Down
4 changes: 2 additions & 2 deletions build/inc/Settings/Component.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ public function render_blocking_method_field() {

echo $select;

$description = '<p class="description">' . __( 'Select a FLoC blocking method suitable for your system. <br />You can learn more about the blocking methods in the help section of this page.' ) . '</p>';
$description = '<p class="description">' . __( 'Select a FLoC blocking method suitable for your system. <br />You can learn more about the blocking methods in the help section of this page.', 'wpm-floc' ) . '</p>';

echo $description;
}
Expand All @@ -162,7 +162,7 @@ public function render_floc_text() {

echo $button;

$description = '<p class="description">' . __( 'Click this button to check if the FLoC header is present in the frontend.' ) . '</p>';
$description = '<p class="description">' . __( 'Click this button to check if the FLoC header is present in the frontend.', 'wpm-floc' ) . '</p>';

echo $description;
}
Expand Down