Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init with vite, react, typescript and tailwind #1

Merged
merged 19 commits into from
Nov 8, 2023
Merged

init with vite, react, typescript and tailwind #1

merged 19 commits into from
Nov 8, 2023

Conversation

nexxeln
Copy link
Contributor

@nexxeln nexxeln commented Nov 7, 2023

  • set up a basic vite + react project
  • set up eslint with basic rules for react and typescript projects
  • set up tailwind
  • set up prettier
  • set up ci using github actions

.github/workflows/ci.yml Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
public/vite.svg Outdated Show resolved Hide resolved
@@ -0,0 +1,4 @@
{
"useTabs": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am personally a space person, maybe discuss this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabs are more accessible. its an objective statement that tabs are better

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine

@WizzyGeek
Copy link
Collaborator

@Dhananjay-Chauhan I need write access, branch protection seems to be not configured

@Meetesh-Saini
Copy link
Member

@Dhananjay-Chauhan I need write access, branch protection seems to be not configured

I have configured it.

@Dhananjay-Chauhan
Copy link
Contributor

@Dhananjay-Chauhan I need write access, branch protection seems to be not configured

@WizzyGeek Write access granted.

@Meetesh-Saini
Copy link
Member

Why are you not using swc? @nexxeln

@nexxeln
Copy link
Contributor Author

nexxeln commented Nov 7, 2023

Why are you not using swc? @nexxeln

no need, vite is more than enough and also swc is a huge binary

@Meetesh-Saini
Copy link
Member

Why are you not using swc? @nexxeln

no need, vite is more than enough and also swc is a huge binary

I agree that the vite is enough but swc offers faster compilation. The builds will take less time.

@nexxeln
Copy link
Contributor Author

nexxeln commented Nov 8, 2023

I agree that the vite is enough but swc offers faster compilation. The builds will take less time.

our site isn't gonna be that big to make a meaningful difference. especially with vit wifi speeds where downloading a huge binary is gonna waste a lot of time

@WizzyGeek WizzyGeek merged commit 667629f into master Nov 8, 2023
4 checks passed
@WizzyGeek WizzyGeek deleted the init branch January 20, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants