Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease changes #798

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Prerelease changes #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
libfm-qt-1.1.0 / 2022-04-15
============================
* Prepared libfm-qt for implementing "Recent Files".
* Silenced Valgrind about an uninitialized value.
* Corrected a typo that could have caused crash.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 'caused a crash'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 'caused a crash'?

It didn't cause any crash because it wasn't used anywhere.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant that part of the sentence looks a bit odd (to me at least) without the 'a' in there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry for my misunderstanding!

I think articles can be dropped sometimes. There's no exact rule, but here "crash" is meant very generally — although I omitted the "a" without thinking. (see https://english.stackexchange.com/questions/38759/whats-the-general-rule-for-dropping-articles-in-article-section-titles-or-in → back to disk).

* Prevented memory leak in `fm_search_to_gfile()`.
* Made `selectFiles()` return bool in FolderView.
* Fixed "Move Bookmark Down" in bookmark context menu.
* Added some icons to bookmark context menu.
* Fixed file association with empty `XDG_CURRENT_DESKTOP`.
* Do not add (null) to terminal command (with terminal emulators like Kitty, that don't have a special option for execution).
* Added protected API to get the internal dialog of `FileDialog`.
* Fixed the file count in the properties dialog of the search folder and removed critical GLib errors in special cases of searching.
* Fixed MIME types cbz, cbr and rar in `archivers.list`.
* A small cleanup for `Fm::Folder`.

libfm-qt-1.0.0 / 2021-11-04
============================
* Added mount, unmount and eject actions to file context menu where possible.
Expand Down
8 changes: 4 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ project(libfm-qt)
set(LIBFM_QT_LIBRARY_NAME "fm-qt" CACHE STRING "fm-qt")

set(LIBFM_QT_API_VERSION_MAJOR 1)
set(LIBFM_QT_API_VERSION_MINOR 0)
set(LIBFM_QT_API_VERSION_MINOR 1)
set(LIBFM_QT_API_VERSION_PATCH 0)
set(LIBFM_QT_API_VERSION ${LIBFM_QT_API_VERSION_MAJOR}.${LIBFM_QT_API_VERSION_MINOR}.${LIBFM_QT_API_VERSION_PATCH})

Expand All @@ -23,12 +23,12 @@ list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake")
# universal way to translate a libtool version-info to a cmake version.
# We use "(current-age).age.revision" as the cmake version.
# current: 6, revision: 0, age: 0 => version: 6.0.0
set(LIBFM_QT_ABI_VERSION "10.0.0")
set(LIBFM_QT_SOVERSION "10")
set(LIBFM_QT_ABI_VERSION "11.0.0")
set(LIBFM_QT_SOVERSION "11")

set(GLIB_MINIMUM_VERSION "2.50.0")
set(LIBMENUCACHE_MINIMUM_VERSION "1.1.0")
set(LXQTBT_MINIMUM_VERSION "0.10.0")
set(LXQTBT_MINIMUM_VERSION "0.11.0")
set(QT_MINIMUM_VERSION "5.15.0")

find_package(Qt5Widgets "${QT_MINIMUM_VERSION}" REQUIRED)
Expand Down