xdgdesktopfile: Avoid freeze for DBusActivatable apps #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For case when the DBusActivatable application is unresponsive the startDetached() can block for a long time (the Qt default 25s DBus timeout). Blocking can't be avoided while using QDBusInterface, because the object can block directly in its contructor. So we use the generated interface class and set the timeout for the DBus call to 1500ms (can be overriden env variable QTXDG_DBUSACTIVATE_TIMEOUT). See also: https://bugreports.qt.io/browse/QTBUG-75016
|
@luis-pereira please, take a look into the cmake part |
luis-pereira
approved these changes
Apr 9, 2019
| @@ -1,3 +1,5 @@ | |||
| set(CMAKE_INCLUDE_CURRENT_DIR ON) | |||
There was a problem hiding this comment.
With lxqt/lxqt-build-tools#46 it's not needed anymore.
But it doesn't hurts if it gets merged before lxqt/lxqt-build-tools#46. It can be removed later on.
|
Works amazing. Panel freezes only for QTXDG_DBUSACTIVATE_TIMEOUT amount of time and doesn't crash, in the background 25 sec later
|
|
GTM |
|
unblocked for debian buster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For case when the DBusActivatable application is unresponsive the
startDetached() can block for a long time (the Qt default 25s DBus
timeout). Blocking can't be avoided while using QDBusInterface, because
the object can block directly in its contructor.
So we use the generated interface class and set the timeout for the DBus
call to 1500ms (can be overriden env variable QTXDG_DBUSACTIVATE_TIMEOUT).
See also: https://bugreports.qt.io/browse/QTBUG-75016
fixes #181