Skip to content

Commit

Permalink
Add qtxdg-tools as a dependency (#428)
Browse files Browse the repository at this point in the history
Needs lxqt/qtxdg-tools#2

Part of qtxdg split. See lxqt/lxqt#2139
  • Loading branch information
Chih-Hsuan Yen authored May 2, 2022
1 parent db2bf51 commit 4cc903f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ option(WITH_LIBUDEV "Build with libudev support" ON)
# Minimum Versions
set(KF5_MINIMUM_VERSION "5.36.0")
set(LXQT_MINIMUM_VERSION "1.1.0")
set(QTXDG_MINIMUM_VERSION "3.9.0")
set(QT_MINIMUM_VERSION "5.15.0")

find_package(Qt5DBus ${QT_MINIMUM_VERSION} REQUIRED)
Expand All @@ -29,6 +30,7 @@ find_package(Qt5Widgets ${QT_MINIMUM_VERSION} REQUIRED)
find_package(Qt5X11Extras ${QT_MINIMUM_VERSION} REQUIRED)
find_package(KF5WindowSystem ${KF5_MINIMUM_VERSION} REQUIRED)
find_package(lxqt ${LXQT_MINIMUM_VERSION} REQUIRED)
find_package(qtxdg-tools ${QTXDG_MINIMUM_VERSION} REQUIRED)

This comment has been minimized.

Copy link
@Fat-Zer

Fat-Zer May 4, 2022

Contributor

If it's a runtime dependency (as stated bellow), why is it required during the build time?

This comment has been minimized.

Copy link
@yan12125

yan12125 May 5, 2022

Member

It's a way to inform users about a new dependency - many people don't read release notes. Is there a reason that you don't want this at build time?

This comment has been minimized.

Copy link
@tsujan

tsujan May 5, 2022

Member

why is it required during the build time?

It's too important to be missed.

find_package(X11 REQUIRED)
message(STATUS "Building with Qt${Qt5Core_VERSION}")
find_package(PkgConfig REQUIRED)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Technically those binaries are basically launched according to the XDG [Autostar

### Compiling source code

Runtime dependencies are xdg-user-dirs and [liblxqt](https://github.com/lxqt/liblxqt).
Runtime dependencies are xdg-user-dirs, [liblxqt](https://github.com/lxqt/liblxqt) and [qtxdg-tools](https://github.com/lxqt/qtxdg-tools).
Additional build dependencies are CMake and optionally Git to pull latest VCS checkouts.

Code configuration is handled by CMake. CMake variable `CMAKE_INSTALL_PREFIX` has to be set to `/usr` on most operating systems.
Expand Down

0 comments on commit 4cc903f

Please sign in to comment.