Draft: Move all SK functionality into core #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dbarrow257, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
github-actions
bot
added
title needs formatting
MCMC
…/mach3-software/MaCh3 into dbarrow257/feature/MoveSKFeaturesToCore
dbarrow257
commented
Feb 13, 2025
| @@ -27,6 +27,7 @@ jobs: | |||
| # Clone the MaCh3Tutorial repository with the current branch | |||
| git clone --branch main https://github.com/mach3-software/MaCh3Tutorial.git MaCh3Validations | |||
| cd MaCh3Validations | |||
| git checkout dbarrow257/feature/MoveSKFeaturesToCore | |||
There was a problem hiding this comment.
This should be undone before approving
| @@ -78,6 +78,7 @@ jobs: | |||
| cd /opt/ | |||
| git clone https://github.com/mach3-software/MaCh3Tutorial.git MaCh3Validations | |||
| cd MaCh3Validations | |||
| git checkout dbarrow257/feature/MoveSKFeaturesToCore | |||
There was a problem hiding this comment.
This should be undone before approving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Move all SK nice code functionality into core and take advantage of the MaCh3Modes object in samplePDFFDBase
Changes or fixes
Examples