Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(supported-versions): add release date #100

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

damienwebdev
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Previously, we didn't take into account a release date, which meant that @Vinai could not add MageOS or Magento releases before the actual day of release.

Touches: #20

What is the new behavior?

With this, we can now add the releases to supported versions before a release comes out without impacting the actual output of supported-version for users. This has two side effects:

  1. It allows us to make a kind that allows testing MageOS and Magento Mirror releases more quickly on release day
  2. We don't have to scramble the day of a release to add the new release to supported-version, we can do so a few weeks ahead of time.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Previously, we didn't take into account a release date, which meant
that @Vinai could not add MageOS or Magento releases before the actual
day of release.

With this, we can now add the releases to supported verisons before
a release comes out, allowing us to make a kind that allows testing
MageOS and Magento Mirror releases more quickly.
@damienwebdev damienwebdev requested a review from Vinai August 15, 2023 21:19
@mage-os-ci mage-os-ci merged commit 5599a0d into main Aug 16, 2023
@mage-os-ci mage-os-ci mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants