[DSC] Implement Phenomenon Investigators #13184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
I think @PurpleCrowbar usually takes care of those images, I don't remember offhand how to do them
edit: it's in Mage.Client/src/main/java/org/mage/plugins/card/dl/sources/ScryfallImageSupportTokens.java
| } | ||
| } | ||
|
|
||
| class PhenomenonInvestigatorsReturnCost extends CostImpl { |
There was a problem hiding this comment.
hm, so this is because the common classes hardcode "controlled"?
There was a problem hiding this comment.
Yes. I'm not aware of any other cards that let you return non-controlled permanents to your hand as a cost, so I figured it'd be easiest to just write a custom class for this one exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no image for the Horror enchantment creature token it creates, but from what I can tell token images are usually added all at once for each set? If so, this should be good to go.