-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout catalog_category_view - fallback mechanism Fixed #835
base: develop
Are you sure you want to change the base?
Conversation
Need to move this file to the layout folder instead of page_layout
Moving this file from page_layout to layout folder so fallback mechanism work as expected.
Create catalog_category_view.xml
CC : @sidolov |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests EE |
@magento run Functional Tests B2B |
1 similar comment
@magento run Functional Tests B2B |
The Functional B2B test seems flaky. The failures are different in last 2 consecutive runs. Please refer to the below screenshots: Hence moving this PR in testing. Thanks |
❌ QA not Passed PreconditionMagento Page Builder version >= 1.3.0 Manual Testing Scenario
Expected Result: ✔️
Actual Result: ✖️ |
Description (*)
Task
A layout file was added in page_layout so the fallback mechanism not working as expected.
usually, this not identify in normal cases but if we will working on layout updates then this causes concern so fixed and moved the layout file to a valid location.
Fixed Issues (if relevant)
page_layout
xml file. #537: Layout shouldn't be set in a page_layout xml file.