Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout catalog_category_view - fallback mechanism Fixed #835

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

kanhaiya5590
Copy link

@kanhaiya5590 kanhaiya5590 commented Nov 29, 2022

Description (*)

Task

A layout file was added in page_layout so the fallback mechanism not working as expected.

usually, this not identify in normal cases but if we will working on layout updates then this causes concern so fixed and moved the layout file to a valid location.

Fixed Issues (if relevant)

  1. layout 2 columns left avoid to override layout on catalog_category_view #829: layout 2 columns left avoid to override layout on catalog_category_view
  2. Layout shouldn't be set in a page_layout xml file. #537: Layout shouldn't be set in a page_layout xml file.

Need to move this file to the layout folder instead of page_layout
Moving this file from page_layout to layout folder so fallback mechanism work as expected.
Create catalog_category_view.xml
@kanhaiya5590 kanhaiya5590 changed the title Layout - fallback mechanism Fixed Layout catalog_category_view - fallback mechanism Fixed Nov 29, 2022
@kanhaiya5590
Copy link
Author

CC : @sidolov

@kanhaiya5590
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review November 25, 2024 10:56
Copy link
Collaborator

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kanhaiya5590,

Thanks for the contribution!

Please fix the failed automated test.

Thanks

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests B2B

1 similar comment
@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Collaborator

The Functional B2B test seems flaky. The failures are different in last 2 consecutive runs. Please refer to the below screenshots:

Run 1 B2b functional Test
image

Run 2 B2b functional Test
image

Hence moving this PR in testing.

Thanks

@engcom-Hotel engcom-Hotel added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Dec 23, 2024
@engcom-Hotel
Copy link
Collaborator

❌ QA not Passed

Precondition

Magento Page Builder version >= 1.3.0

Manual Testing Scenario

  1. Create a layout/catalaog_category_view.xml in your theme.
  2. Set the attribute layout of the xml-node page to 1column

Expected Result: ✔️

  • Category page has layout one column

Actual Result: ✖️

  • Category page has still 2 column layout
    image

cc: @antoniocarboni @jasperzeinstra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: needs update Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

3 participants