Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExceptionHandler doesn't show actual file & line of exception thrown #39415

Open
5 tasks
webloft opened this issue Nov 30, 2024 · 7 comments · May be fixed by #39453
Open
5 tasks

ExceptionHandler doesn't show actual file & line of exception thrown #39415

webloft opened this issue Nov 30, 2024 · 7 comments · May be fixed by #39453
Labels
Area: Framework Component: Framework/Exception Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@webloft
Copy link

webloft commented Nov 30, 2024

Summary

We know there are tickets addressing exception handling, however did you guys realize that

magento2/lib/internal/Magento/Framework/App/ExceptionHandler.php

Line 116 in 88660e7

private function buildContentFromException(\Exception $exception): string

suppresses the file and line of the actual exception?

Examples

Exception inside a template - we'll see something like that:

Exception #0 (Exception): A test exception

#1 Magento\Framework\View\TemplateEngine\Php->render() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#2 Magento\Framework\View\TemplateEngine\Php\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]

Completely useless.

We want to see:

Exception #0 (Exception): A test exception thrown in path/file.phtml:100

#1 Magento\Framework\View\TemplateEngine\Php->render() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#2 Magento\Framework\View\TemplateEngine\Php\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]

Proposed solution

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@webloft webloft added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Nov 30, 2024
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 30, 2024

Hi @webloft. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Nov 30, 2024
@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Dec 2, 2024
@engcom-Hotel engcom-Hotel self-assigned this Dec 2, 2024
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Dec 2, 2024

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel
Copy link
Contributor

Hello @webloft,

Thanks for the report and collaboration!

Please provide us with more information on the issue, like:

  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Thanks

@engcom-Hotel engcom-Hotel added Issue: needs update Additional information is require, waiting for response and removed Issue: ready for confirmation labels Dec 2, 2024
@engcom-Hotel engcom-Hotel moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Dec 2, 2024
@webloft
Copy link
Author

webloft commented Dec 2, 2024 •
edited
Loading

@engcom-Hotel

Environment doesn't matter.

Steps to reproduce:

put

throw new Exception('A test');

Inside any frontend template. You will see that the exception is thrown without any information about the template or line number since this information is cut off in the exception handler, thanks.

@engcom-Hotel
Copy link
Contributor

Hello @webloft,

Thanks for the reply!

We have tried to reproduce the issue in the 2.4-develop branch and it is reproducible for us. Please refer to the screenshot below for reference:

image

Hence confirming the issue. You can also raise a community PR to fix this issue.

Thanks

@engcom-Hotel engcom-Hotel added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P3 May be fixed according to the position in the backlog. and removed Issue: needs update Additional information is require, waiting for response labels Dec 4, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13460 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Dec 4, 2024

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

GrassH added a commit to GrassH/magento2 that referenced this issue Dec 10, 2024
@GrassH
magento#39415 - Fixed an issue where the ExceptionHandler did not dis…
39ce6b9 
…play the correct file and line number of the thrown exception.
@GrassH GrassH linked a pull request Dec 10, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Framework Component: Framework/Exception Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
4 participants
@webloft @engcom-Bravo @engcom-Hotel @github-jira-sync-bot