Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#39415 - Fixed an issue where the ExceptionHandler did not display the correct file and line number of the thrown exception. #39453

Open
wants to merge 9 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

GrassH
Copy link
Contributor

@GrassH GrassH commented Dec 10, 2024

Description (*)

Fix #39415

Fixed Issues (if relevant)

  1. Fixes ExceptionHandler doesn't show actual file & line of exception thrown #39415

Manual testing scenarios (*)

  1. Add the following line of code to any .phtml file:
    <?php throw new \Exception('Test'); ?>
  2. In developer mode, navigate to the page corresponding to the modified .phtml file.
  3. An error will be thrown, displaying the following exception message:
    Exception #0 (Exception): "Test" thrown at [app/code/Magento/Catalog/view/frontend/templates/product/list.phtml:7]

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Dec 10, 2024

Hi @GrassH. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@GrassH
Copy link
Contributor Author

GrassH commented Dec 10, 2024

@magento run all tests

@GrassH
Copy link
Contributor Author

GrassH commented Dec 10, 2024

@magento run all tests

@engcom-Hotel engcom-Hotel added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Priority: P3 May be fixed according to the position in the backlog. labels Dec 10, 2024
@GrassH
Copy link
Contributor Author

GrassH commented Dec 11, 2024

@magento run all tests

@GrassH
Copy link
Contributor Author

GrassH commented Dec 13, 2024

@magento run all tests

@GrassH
Copy link
Contributor Author

GrassH commented Dec 16, 2024

@magento run all tests

@GrassH
Copy link
Contributor Author

GrassH commented Dec 19, 2024

@magento run all tests

@GrassH
Copy link
Contributor Author

GrassH commented Dec 23, 2024

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExceptionHandler doesn't show actual file & line of exception thrown
2 participants